Rename MidiTime to TimePos #5684
Merged
+622
−618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good candidate to be part of #5592 which is targeted around December. |
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://10907-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.29%2Bg18f5941-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10907?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://10905-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.29%2Bg18f594118-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10905?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://10906-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.29%2Bg18f594118-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10906?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/6qbs4km13op8giyu/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36565864"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/86tp2jq7lwadsana/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36565864"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://10909-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.29%2Bg18f594118-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10909?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "0ab37b98fda2a0c60ba96d8650388df9e50ccffa"} |
56 tasks
M374LX
force-pushed
the
rename-miditime-timepos
branch
from
fd94df8 to
bc4ae05
Compare
JohannesLorenz
requested changes
Nov 29, 2020
JohannesLorenz
approved these changes
Nov 29, 2020
IanCaio
added a commit
to IanCaio/lmms
that referenced
this pull request
Nov 30, 2020
Resolves conflict introduced by PR LMMS#5684.
IanCaio
pushed a commit
to IanCaio/lmms
that referenced
this pull request
Mar 28, 2021
devnexen
pushed a commit
to devnexen/lmms
that referenced
this pull request
Apr 10, 2021
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redoing #4897 and #5295 after both were unsuccessfully closed.
Closes #4866.