Avoid creating TCOs while rendering

[Reflexe]

No description provided.

[LmmsBot]

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Windows

• Windows 32-bit: lmms-1.2.0-rc6.779-mingw-win32.exe (build link)
• Windows 64-bit: lmms-1.2.0-rc6.779-mingw-win64.exe (build link)
• Windows 32-bit: lmms-1.2.1-msvc2017-win32.exe (build link)
• Windows 64-bit: lmms-1.2.1-msvc2017-win64.exe (build link)

macOS

• macOS : lmms-1.2.0-rc6.779-mac10.13.dmg (build link)

🤖

{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://1474-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.779-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1474?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://1478-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.779-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1478?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/up3njfc1rbo9srwp/artifacts/build/lmms-1.2.1-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/31949511"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/oc1t9rf0gli88nv0/artifacts/build/lmms-1.2.1-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/31949511"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://1475-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.779-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1475?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "dbe60d8537da739c39acf1e8303fbb93da82d09b"}

[PhysSong]

I think this is overkill. Creating a TCO shouldn't cause any race conditions with Mixer as you addressed in this PR, but I think you can somehow minimize actions within the requestChangeInModel()~doneChangeInModel() block. We should take care of realtime safety while considering thread safety as well.
The first commit looks good, though.

[PhysSong]

@Reflexe Is it okay to cherry-pick the first commit to master and close this PR for now?

[Reflexe]

No problem. Thanks.

…

On Sat, 18 Jun 2022, 09:28 Hyunjin Song, ***@***.***> wrote: @Reflexe <https://github.com/Reflexe> Is it okay to cherry-pick the first commit to master and close this PR for now? — Reply to this email directly, view it on GitHub <#5436 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFOMGKABVBNH2ER4TH6MSS3VPVUALANCNFSM4L5JUX7Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[PhysSong]

Done via 371f7f5, with minor changes.