Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set loop points from right-clicking pattern, first draft. #5239

Closed
wants to merge 2 commits into from

Conversation

softrabbit
Copy link
Member

Doesn't yet work for sample tracks or automation. I'll be amending the PR with support for those in a few days. Critique is most welcome, as I'm not entirely up to speed on the GUI side of things here.

Doesn't yet work for sample tracks or automation.
@softrabbit softrabbit changed the title Set loop points from pattern, first draft. Set loop points from right-clicking pattern, first draft. Oct 13, 2019
@softrabbit softrabbit added rework required Pull requests which must be reworked to make it able to merge or review and removed in progress labels Apr 9, 2021
@PhysSong PhysSong removed the rework required Pull requests which must be reworked to make it able to merge or review label Nov 12, 2022
@PhysSong PhysSong marked this pull request as draft November 12, 2022 11:26
@LMMS LMMS deleted a comment from LmmsBot Nov 12, 2022
@PhysSong
Copy link
Member

Why don't you just use ClipView::contextMenuEvent?

@softrabbit
Copy link
Member Author

Why don't you just use ClipView::contextMenuEvent?

No idea, really... it's been close to 5 years now so who cares? 😁
It was probably because I found the spot where the context menu was constructed and added to that.

@softrabbit softrabbit closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants