Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide reasons for "message not supported" #39

Closed
AlexanderRitter02 opened this issue Apr 24, 2023 · 7 comments
Closed

Provide reasons for "message not supported" #39

AlexanderRitter02 opened this issue Apr 24, 2023 · 7 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@AlexanderRitter02
Copy link

Description

Hi,
WhatsApp meta messages like:

  • Chat is end-to-end encrypted...
  • This message was deleted

are currently treated as "This message is not supported".

As noted in this comment, it's not a bug:
#9 (comment)

Metadata is also treated as messages in the database. But since it is not the main focus when it comes to exporting chats, metadata may show as "not supported" unless handled like changes of the group name. Therefore, I will consider it not a bug if the chat is complete.

This is mostly fine, but can cause concern among users thinking some messages are missing (and not everyone searches Github to find the issue).

Suggestion

I suggest additionally providing the reason why the message is not supported (e.g. deleted message or whatsapp internal message) instead of the generic comment that the message is not supported.
This will make it clear that the message is not important.

It would be useful to alleviate the concerns of missing messages if looking through the backup at a later time.

You do detect that these messages are unsupported, so if individually detecting the type is infeasible, an option would also be to make the message less intimidating:
A Whatsapp internal message (phone changed, deleted messages, ...) is not supported

@KnugiHK
Copy link
Owner

KnugiHK commented Apr 25, 2023

"This message was deleted" is supposed to be handled. At least it is handled before we move to the new schema. Therefore, it should be considered a bug.

I agree we can add the reason why certain messages are not supported. On the other hand, we can also hide the metadata messages from the output. What do you think?

KnugiHK added a commit that referenced this issue Apr 25, 2023
@KnugiHK
Copy link
Owner

KnugiHK commented Apr 25, 2023

The missing of "Message deleted" should be fixed in c7a01bb.

@KnugiHK KnugiHK self-assigned this May 5, 2023
@KnugiHK KnugiHK added bug Something isn't working enhancement New feature or request labels May 5, 2023
@kintaro1981
Copy link

I can confirm that "Message deleted" is fixed, I just tried with a iOS db.

How about supporting the other ones like, " has left the group"?

I want to use Whatsapp-Chat-Exporter to archive many of my WA chats and free up space in the phone, but I would like in the future, for example, to know when a user left a group.

@KnugiHK
Copy link
Owner

KnugiHK commented Jun 10, 2023

I can confirm that "Message deleted" is fixed, I just tried with a iOS db.

How about supporting the other ones like, " has left the group"?

I want to use Whatsapp-Chat-Exporter to archive many of my WA chats and free up space in the phone, but I would like in the future, for example, to know when a user left a group.

More metadata will be supported in the future, I assume. But since parsing metadata requires understanding their binary representation, there is yet to be a timeline for their implementation.

@KnugiHK
Copy link
Owner

KnugiHK commented Jun 15, 2023

I can confirm that "Message deleted" is fixed, I just tried with a iOS db.
How about supporting the other ones like, " has left the group"?
I want to use Whatsapp-Chat-Exporter to archive many of my WA chats and free up space in the phone, but I would like in the future, for example, to know when a user left a group.

More metadata will be supported in the future, I assume. But since parsing metadata requires understanding their binary representation, there is yet to be a timeline for their implementation.

FYI, 011c8ff implemented a metadata handling related to missed calls.

@KnugiHK
Copy link
Owner

KnugiHK commented Jun 20, 2023

Another FYI, 3ed269e & 030fef5 introduced a lot of metadata handling for Android.

@KnugiHK
Copy link
Owner

KnugiHK commented Jun 25, 2023

Released in 0.9.5.

@KnugiHK KnugiHK closed this as completed Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants