Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The purge #34

Merged
merged 8 commits into from
Oct 7, 2023
Merged

The purge #34

merged 8 commits into from
Oct 7, 2023

Conversation

jepeteo
Copy link
Contributor

@jepeteo jepeteo commented Sep 28, 2023

Cleared the old code, removed phonegap, glyphicons bootstrap.
Move the project to root folder.
Created config file in the js directory to use for api key and other sensitive information.
Created example config file.
Redeisign the project from scratch with Tailwind CSS.
Added deathdate, birthday and image to the results.
Used Heroricons as svg for performance.

@jepeteo jepeteo requested a review from kapcom01 September 28, 2023 04:54
@jepeteo jepeteo changed the title The purge resolves #23, resolves #32, resolves #33 The purge Oct 1, 2023
Copy link
Contributor Author

@jepeteo jepeteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changed directory and files structure
  • loaded the tailwindcss the correct way (through npm)
  • refactored actor cards (added skeleton loading to actor images)
  • added some more styles through tailwind
  • added some documentation
  • the search now handles no results and show the appropriate message

@kapcom01
Copy link
Member

kapcom01 commented Oct 7, 2023

Can you please guide me through the installation process so I can test that the code works?

I checked out the-purge branch, added a new public/js/the_config.js file from the template and filled in the API key.
Then I opened public/index.html with a browser but the graphics were broken and the search box was not working.

@kapcom01 kapcom01 merged commit 176a835 into master Oct 7, 2023
@kapcom01
Copy link
Member

kapcom01 commented Oct 7, 2023

ok, it works. it just needed to run the files from a web server. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move tmdb API key to backend move source code to root directory show birthdate & deathdate
2 participants