Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: readds responsive image styling #404

Merged
merged 1 commit into from
Mar 25, 2025
Merged

style: readds responsive image styling #404

merged 1 commit into from
Mar 25, 2025

Conversation

anechol
Copy link
Contributor

@anechol anechol commented Mar 21, 2025

Description

Re-adds responsive image styling that was removed in a previous commit. Image should now scale down with the viewport instead of overflowing.

Fixes #(issue)

Type of change

Before:
Screenshot 2025-03-21 at 3 57 15 PM

After:
Screenshot 2025-03-21 at 3 57 06 PM

  • Style (adds, updates, or removes component styling)

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@anechol anechol self-assigned this Mar 21, 2025
@github-actions github-actions bot added the package: core Changes have been made to the Core package label Mar 21, 2025
Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 81cdf4f
🔍 Latest deploy log https://app.netlify.com/sites/pine-design-system/deploys/67ddd2ef7362f900087c518c
😎 Deploy Preview https://deploy-preview-404--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anechol anechol merged commit 06ec2eb into main Mar 25, 2025
16 checks passed
@anechol anechol deleted the style/image-sizing branch March 25, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core Changes have been made to the Core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants