fix: add padding-block and padding-inline properties #399
+219
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
QuintonJason
changed the title
pixelflips
approved these changes
Mar 12, 2025
ju-Skinner
reviewed
Mar 13, 2025
| * Defines the vertical alignment of the box items. | ||
| * @defaultValue start | ||
| */ | ||
| @Prop() alignSelf?: `start` | `center` | `end` | `baseline` | `stretch`; |
ju-Skinner
reviewed
Mar 13, 2025
| const element = page.root; | ||
| expect(element).toHaveClass(`pds-padding-inline-${size}`); | ||
| }); | ||
|
|
There was a problem hiding this comment.
There are no specs for alignSelf as well.
ju-Skinner
requested changes
Mar 13, 2025
QuintonJason
force-pushed
the
fix/box-padding-block-inline
branch
from
bbe39d3 to
7d2cb47
Compare
ju-Skinner
reviewed
Mar 26, 2025
ju-Skinner
approved these changes
Mar 26, 2025
pixelflips
reviewed
Mar 26, 2025
| @@ -283,7 +283,79 @@ $pine-spacing-tokens: ( | |||
| padding: var(--pine-dimension-2xl); | |||
| } | |||
|
|
|||
| .pds-padding-block-none { | |||
| padding-block: 0; | |||
There was a problem hiding this comment.
Nitpick but could this use --pine-dimension-none?
pixelflips
approved these changes
Mar 26, 2025
| } | ||
|
|
||
| .pds-padding-inline-none { | ||
| padding-inline: 0; |
There was a problem hiding this comment.
Same --pine-dimension-none here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue is to remedy a request that came into DS-Support
padding-blockandpadding-inlineto allow for more padding flexibilityalign-selffor alignment flexibility within flex containersFixes DSS-1309
Type of change
How Has This Been Tested?
Please describe the tests you've added and run to verify your changes.
Provide instructions so that we can reproduce.
Please also list any relevant details for your test configuration.
Test Configuration:
Checklist:
If not applicable, leave options unchecked.