Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QML: Rename Scripts module #56

Closed
LeonMatthesKDAB opened this issue Jun 24, 2024 · 1 comment · May be fixed by #86
Closed

QML: Rename Scripts module #56

LeonMatthesKDAB opened this issue Jun 24, 2024 · 1 comment · May be fixed by #86
Assignees
@LeonMatthesKDAB
Labels
🙋 good first issue Good for newcomers 👷 refactor Something needs to change
Milestone
Release 1.0.0

Comments

@LeonMatthesKDAB
Copy link
Collaborator

The Scripts name is somewhat nondescript.

We should rename this to Knut, or com.kdab.knut before releasing v1.0.
The exact name still needs to be chosen.
@LeonMatthesKDAB LeonMatthesKDAB added 🙋 good first issue Good for newcomers ❔ question Further information is requested 👷 refactor Something needs to change labels Jun 24, 2024
@narnaud
Copy link
Member

narnaud commented Jun 24, 2024

I would prefer import Knut

Also take this opportunity to remove all version numbers in QML/JS
That's the new way to do things in Qt, so just import Knut, not import Knut 1.0

@narnaud narnaud added this to the Release 1.0.0 milestone Jun 24, 2024
@narnaud narnaud mentioned this issue Jun 24, 2024
Closed
2 tasks
@narnaud narnaud removed the ❔ question Further information is requested label Jun 24, 2024
narnaud added a commit to narnaud/knut that referenced this issue Jun 30, 2024
@narnaud
fix: Remove version from import
9b06887 
There is no need for a version number, this makes things easier.

Part of KDAB#56
narnaud added a commit to narnaud/knut that referenced this issue Jul 1, 2024
@narnaud
fix: Remove version from import
c8f1efd 
There is no need for a version number, this makes things easier.

Part of KDAB#56
narnaud added a commit that referenced this issue Jul 1, 2024
@narnaud
fix: Remove version from import
512b5e2 
There is no need for a version number, this makes things easier.

Part of #56
@LeonMatthesKDAB LeonMatthesKDAB self-assigned this Jul 8, 2024
LeonMatthesKDAB added a commit to LeonMatthesKDAB/knut that referenced this issue Jul 9, 2024
@LeonMatthesKDAB
refactor!: Rename Script QML module to Knut
15ce9f0 
"import Script" was rather generic, so before release 1.0, we will want
to rename it to "import Knut".

Fix KDAB#56
LeonMatthesKDAB added a commit to LeonMatthesKDAB/knut that referenced this issue Jul 9, 2024
@LeonMatthesKDAB
refactor!: Rename Script QML module to Knut
d848729 
"import Script" was rather generic, so before release 1.0, we will want
to rename it to "import Knut".

Fix KDAB#56
@LeonMatthesKDAB LeonMatthesKDAB mentioned this issue Jul 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeonMatthesKDAB LeonMatthesKDAB

Labels
🙋 good first issue Good for newcomers 👷 refactor Something needs to change
Projects
None yet
Milestone
Release 1.0.0
Development

Successfully merging a pull request may close this issue.

chore(main): release 1.0.0 KDAB/knut
2 participants
@narnaud @LeonMatthesKDAB