CI: Enable -Werror for clazy since we're warning clean now #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're now clazy free and can make clazy use -Werror in CI
dfaure-kdab
reviewed
Mar 3, 2025
CMakeLists.txt
Outdated
| @@ -74,6 +74,7 @@ option(${PROJECT_NAME}_TESTS "Build the tests" OFF) | |||
| option(${PROJECT_NAME}_EXAMPLES "Build the examples" ON) | |||
| option(${PROJECT_NAME}_DOCS "Build the API documentation" OFF) | |||
| option(${PROJECT_NAME}_QT6 "Build against Qt 6" ON) | |||
| option(${PROJECT_NAME}_WERROR "Treat build warnings as errors" OFF) | |||
There was a problem hiding this comment.
CMake provides a builtin option for that already: CMAKE_COMPILE_WARNING_AS_ERROR
I learned that very recently in https://codereview.kdab.com/c/training-material/+/151437
Should we just document to use that instead?
There was a problem hiding this comment.
the preset serves as documentation
dfaure-kdab
reviewed
Mar 3, 2025
CMakeLists.txt
Outdated
| # it doesn't mean we endorse those warnings. | ||
| # MSVC Werror is untested and probably will have a few hundered errors | ||
| if(MSVC) | ||
| add_compile_options(/WX) |
There was a problem hiding this comment.
This can be removed, the cmake option takes care of that
Modules/Compiler/MSVC.cmake:13: set(CMAKE_${lang}_COMPILE_OPTIONS_WARNING_AS_ERROR "-WX")
While this is only being used for clazy now we could also enable it in CI for regular builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.