Don't set clazy settings in multiple places #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed .clazy file which was only read by KDAB CI. Moved env variables from nightly.yml to CMakePresets.json, so users can run clazy locally as well. Adapted nightly.yml to use the preset.
It's no longer a nightly. KDSoap is a small project with little traffic. Doesn't take more than a few minutes anyway.
Allows users to run locally with the same settings and makes the yml file cleaner
dfaure-kdab
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed .clazy file which was only read by KDAB CI. Moved env variables from nightly.yml to CMakePresets.json, so users can run clazy locally as well.
Adapted nightly.yml to use the preset.
Also 2 whitespace changes which I only noticed now, done by editor on save.