Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spec compliance #180

Closed
wants to merge 1 commit into from
Closed

fix spec compliance #180

wants to merge 1 commit into from

Conversation

hsitter
Copy link
Contributor

@hsitter hsitter commented Aug 16, 2019

as per https://www.w3.org/Submission/ws-addressing/ the only well-known
uri in 2004/08 was anonymous and it has a role prefix. from the
implicit reading I can find on earlier versions the same applies to them.

so, when constructing the well-known URIs inject a role prefix when
dealing with specs up to 2004/08 and raise a warning when attempting to
use anything but anonymous

Copy link
Member

@dfaure-kdab dfaure-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caspermeijn Can you take a look?

@hsitter
Copy link
Contributor Author

hsitter commented Aug 16, 2019

@dfaure-kdab btw, do you have an opinion WRT adding a Q_ASSERT(false) to the Anonymous condition? At first that looked like a good idea but then testing would be problematic so I opted not to assert anything.

Copy link
Contributor

@caspermeijn caspermeijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difficulty is of-course that the four specs are subtly different. I think this change will make this difference between the specs more obvious.

@dfaure-kdab
Copy link
Member

@dfaure-kdab btw, do you have an opinion WRT adding a Q_ASSERT(false) to the Anonymous condition? At first that looked like a good idea but then testing would be problematic so I opted not to assert anything.

Asserts prevent writing unittests for these conditions. So it might be better to not assert.
(Not to mention the risk that this gets triggered on data outside the control of the developer, such as server replies, or broken XSD/WSDL files)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
as per https://www.w3.org/Submission/ws-addressing/ the only well-known
uri in 2004/08 was anonymous and it has a role prefix. from the
implicit reading I can find on earlier versions the same applies to them.

so, when constructing the well-known URIs inject a role prefix when
dealing with specs up to 2004/08 and raise a warning when attempting to
use anything but anonymous

same for /id/unspecified
@hsitter
Copy link
Contributor Author

hsitter commented Aug 27, 2019

All comments should be dealt with now. I've also switched back to no assert and added back the test case for the bad-value-for-version scenario.

@caspermeijn
Copy link
Contributor

Looks good to me

@hsitter
Copy link
Contributor Author

hsitter commented Oct 28, 2019

ping

@hsitter hsitter mentioned this pull request Oct 28, 2019
@hsitter
Copy link
Contributor Author

hsitter commented Oct 28, 2019

actually in #193 for reasons...

@hsitter hsitter closed this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants