-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix spec compliance #180
fix spec compliance #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caspermeijn Can you take a look?
@dfaure-kdab btw, do you have an opinion WRT adding a Q_ASSERT(false) to the Anonymous condition? At first that looked like a good idea but then testing would be problematic so I opted not to assert anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difficulty is of-course that the four specs are subtly different. I think this change will make this difference between the specs more obvious.
Asserts prevent writing unittests for these conditions. So it might be better to not assert. |
as per https://www.w3.org/Submission/ws-addressing/ the only well-known uri in 2004/08 was anonymous and it has a role prefix. from the implicit reading I can find on earlier versions the same applies to them. so, when constructing the well-known URIs inject a role prefix when dealing with specs up to 2004/08 and raise a warning when attempting to use anything but anonymous same for /id/unspecified
All comments should be dealt with now. I've also switched back to no assert and added back the test case for the bad-value-for-version scenario. |
Looks good to me |
ping |
actually in #193 for reasons... |
as per https://www.w3.org/Submission/ws-addressing/ the only well-known
uri in 2004/08 was anonymous and it has a role prefix. from the
implicit reading I can find on earlier versions the same applies to them.
so, when constructing the well-known URIs inject a role prefix when
dealing with specs up to 2004/08 and raise a warning when attempting to
use anything but anonymous