Correct svds dimension check. #126
Conversation
|
I'm still pretty new to Julia, so I'm happy to add a regression test if I can be pointed in the right direction! |
|
Can you add a test? |
|
@andreasnoack Is this ok? @joshpoll It would be nice to add a test if possible. |
Co-authored-by: Andreas Noack <[email protected]>
|
@joshpoll See this file for the existing tests and add something at the end of the file: https://github.com/JuliaLinearAlgebra/Arpack.jl/blob/master/test/runtests.jl |
|
Sorry I got sidetracked by the end of the semester! I'll add a test |
|
I'm not sure why this test is failing. It seems unrelated to the PR. A test that should be breaking is passing on nightly. I'm also having trouble reproducing these runs locally, since I'm not sure how to force Julia to use the local modified Arpack. |
|
Yes. I don't think it as anything to do with the changes here so let's consider that in a separate issue. |
Resolves #110.