Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to implementation in runtime #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maniksejwal
Copy link

compile is no longer supported so replaced it with implementation

compile is no longer supported so replaced it with implementation
@guidedways
Copy link

@maniksejwal can you provide us with steps on how to use your repo instead?

@maniksejwal
Copy link
Author

@guidedways
I am sorry, I won't be able to help as I don't know anything about the functioning and design of this library. I was unable to compile my android app because Hugo was still using compile so I just tried changing the gradle files to use implementation.

@thuutin
Copy link

thuutin commented Jul 22, 2019

Hi @maniksejwal, I think usage of compile here also need to be updated to implementation https://github.com/JakeWharton/hugo/blob/master/hugo-plugin/src/main/groovy/hugo/weaving/plugin/HugoPlugin.groovy#L29

In my understanding, this code will be "run" when you apply plugin hugo and it add some more dependencies to the dependencies block of the module.

@maniksejwal
Copy link
Author

Hi @thuutin, seems you are right. The imports and the classes in the file will also need to be updated.

I feel that the project is no longer maintained and creating a new pull request will not be of any use while a for will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants