-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package exports mean node version is always used with Webpack 5 #145
Comments
From the PR at #146 (comment)
Also, when we may be able to revisit this, per the end of https://nodejs.org/api/packages.html#packages_conditional_exports :
|
Describe the bug
The current
package.json
specifies: https://github.com/JSONPath-Plus/JSONPath/blob/v5.0.2/package.json#L7-L10which, if I read https://webpack.js.org/guides/package-exports/ correctly, mean the node version is always imported, even in browser mode.
We noticed this change in behaviour when our JSONPath queries were suddenly taking much longer to run after upgrading from v4.0.0 to v5.0.2. A query that would take < 3ms under v4.0.0 was suddenly taking > 100ms under v5.0.2. Replacing
index-node-esm.mjs
withindex-browser-esm.js
would bring the performance back to normal.The text was updated successfully, but these errors were encountered: