Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatlaf.useRoundedPopupBorder for kde? #949

Open
Shadowblitz16 opened this issue Dec 31, 2024 · 10 comments
Open

flatlaf.useRoundedPopupBorder for kde? #949

Shadowblitz16 opened this issue Dec 31, 2024 · 10 comments

Comments

@Shadowblitz16
Copy link

Not sure if it's possible but it would be nice to see flatlaf.useRoundedPopupBorder supported on kde 5 and up

I am using kubuntu 24.04 which is linux.

@DevCharly
Copy link
Collaborator

That would be indeed nice, but, how to do it for Java apps, which does not use KDE.

Not even JetBrains has managed to implement this yet for IntelliJ IDEA: https://youtrack.jetbrains.com/issue/JBR-7476

@DevCharly
Copy link
Collaborator

Please try PR #964

@Shadowblitz16
Copy link
Author

Please try PR #964

Call me a bad developer but idk how to use PR's

@DevCharly
Copy link
Collaborator

Please try PR #964

Call me a bad developer but idk how to use PR's

see #964 (comment)

@MrUrdam
Copy link

MrUrdam commented Feb 6, 2025

Is this PR covering GNOME as well? Or is it for now just a KDE based solution? :)

@DevCharly
Copy link
Collaborator

Is this PR covering GNOME as well? Or is it for now just a KDE based solution? :)

Yes. It is a pure Java solution and does not use or depend on GNOME or KDE.

@MrUrdam
Copy link

MrUrdam commented Feb 10, 2025

Works great in our environment. Some minor rough edges as described in your PR but nothing extreme. No black glitches yet.
AlmaLinux 9 with GNOME and Java 17

@DevCharly
Copy link
Collaborator

@MrUrdam thanks for testing.
Are there any differences in font rendering, in the rounded popup, compared to FlatLaf 3.5.4?

@MrUrdam
Copy link

MrUrdam commented Feb 14, 2025

Hey @DevCharly I just did a short test last week and rolled back to the current version we are using. We are still not on the latest FlatLaf version.
In my short investigation back then I have not seen any issues or weird glitches.

Would it be possible to add a option to round the corners of the frame via FlatLaf as well? Here it would make sense that the Dev can decide which corners should be rounded as well. In GNOME for example only the top corners are rounded with the when using the System Decirations. With the FlatLaf Window Decorations we could then change the UI to a similar L&F

@DevCharly
Copy link
Collaborator

Would it be possible to add a option to round the corners of the frame via FlatLaf as well?

Yes, that's the next step 😉

Here it would make sense that the Dev can decide which corners should be rounded as well.

Don't think that this is necessary (or worth the effort).
Latest GNOME versions (e.g. on Ubuntu 24.10) are rounded on all four corners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants