feat: Implemented load from absolute path. #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarr21
approved these changes
Apr 13, 2019
ZacSweers
reviewed
Apr 13, 2019
ZacSweers
reviewed
Apr 13, 2019
| final Typeface typeface = Typeface.createFromAsset(assetManager, filePath); | ||
| final File file = new File(filePath); | ||
| final Typeface typeface; | ||
| if(file.isAbsolute()) { |
There was a problem hiding this comment.
better yet, let's just skip the File instance and check the first path char. Per the doc:
On Android, absolute paths start with the character '/'.
There was a problem hiding this comment.
if (filePath.startsWith("/")) {
// Absolute path, so load from that file path
typeface = Typeface.createFromFile(filePath);
} else {
typeface = Typeface.createFromAsset(assetManager, filePath);
}
Merged
|
Squashed and merged in #25, thanks! |
Closed
This was referenced Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using exclusive device.
This device has fonts already installed in
/system/fontsdirectory.I improved to load fonts with absolute path.