New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to handle current version of .mmdb files and use of submodule #7

Merged

IncSW merged 1 commit into IncSW:master from gregorybrzeski:gregorybrzeski_patch_for_tests

Jan 28, 2025

Contributor

gregorybrzeski commented Jan 28, 2025

While preparing to add a new feature I updated tests in the following way:

move test files to separate directories for different sources (MaxMind, DB-IP)
get MaxMind test .mmdb files from their github repo using submodule
update paths for .mmdb files for tests
update tests to match the current (2025-01) version of MaxMind .mmdb test files
update README by adding a section about obtaining test .mmdb files

Let me know what you think.


          update tests to handle current version MMDB files and use of submodule

c36f8d6

Owner

IncSW commented Jan 28, 2025

LGTM. Thank you for the contribution.

IncSW merged commit 98c4e56 into IncSW:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet