648 update description in the spec for the following analyses #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navarroc
reviewed
Mar 28, 2025
| @@ -22,7 +22,7 @@ def __init__(self, incore_client): | |||
| super(PipelineRepairCost, self).__init__(incore_client) | |||
|
|
|||
| def run(self): | |||
| """Executes pipline facility repair cost analysis.""" | |||
| """Executes pipline repair cost analysis.""" | |||
navarroc
reviewed
Mar 28, 2025
| @@ -188,65 +188,66 @@ def get_spec(self): | |||
| """ | |||
| return { | |||
| "name": "pipeline-repair-cost", | |||
| "description": "Pipeline repair cost analysis.", | |||
| "description": "This analysis estimates the repair costs of water pipeline for different " | |||
There was a problem hiding this comment.
I could be wrong, but I don't think this is limited to water pipelines.
navarroc
reviewed
Mar 28, 2025
| @@ -654,49 +655,49 @@ def get_spec(self): | |||
| { | |||
| "id": "dfr3_mapping_set", | |||
| "required": True, | |||
| "description": "DFR3 Mapping Set Object", | |||
| "description": "DFR3 mapping set containing rules to map DFR3 curves to the pipeline inventory.", | |||
|
Looks good overall, just a few minor things and this should be ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.