Fixes #654 - changed hazard service earthquake post method to allow soil type dataset #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser to specify soil type dataset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Java service endpoint for earthquake allows a user to specify the soil type information, but the python method doesn't have any way to add the dataset id so the service will amplify the hazard based on the soil information at the location specified (otherwise it defaults to whatever soil type is specified when creating the earthquake).
Rather than adding another parameter to the method and then updating the earthquake python model, I added this information to the payload and checked for it in the service to see if it's present. I am not sure if this is the best way to do this so I am open to other options.