Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reverse up / down device option #361

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Add reverse up / down device option #361

merged 2 commits into from
Mar 11, 2022

Conversation

maljoras
Copy link
Collaborator

Description

Add a new option to LinearStepDevice / SoftBoundsDevice to reverse the up / down asymmetry.

Details

For example:

from aihwkit.simulator.configs.devices import SoftBoundsDevice
from aihwkit.utils.visualization import plot_device_compact

plot_device_compact(SoftBoundsDevice(reverse_up=False, reverse_down=True, w_min_dtod=0.0,                                w_max_dtod=0.0), n_steps=1000)

image

or

plot_device_compact(SoftBoundsDevice(reverse_up=True, reverse_down=False, reverse_offset=0.1, w_min_dtod=0.0,
                                     w_max_dtod=0.0), n_steps=1000)

image

@maljoras maljoras added the enhancement New feature or request label Mar 11, 2022
@maljoras maljoras self-assigned this Mar 11, 2022
@maljoras maljoras requested a review from Fabio-83 March 11, 2022 16:56
Fabio-83
Fabio-83 previously approved these changes Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@Fabio-83 Fabio-83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @maljoras

@maljoras maljoras requested a review from Fabio-83 March 11, 2022 17:07
@maljoras maljoras merged commit 8ac7783 into IBM:master Mar 11, 2022
@maljoras maljoras deleted the reverse_linear_step branch March 11, 2022 17:10
maljoras added a commit to todd-deshane/aihwkit that referenced this pull request Jul 26, 2022
@maljoras
Add reverse up / down device option (IBM#361)
d9ba4d6 
Signed-off-by: Malte Rasch <[email protected]>
HCY-11 pushed a commit to HCY-11/aihwkit that referenced this pull request Dec 6, 2022
@maljoras @HCY-11
Add reverse up / down device option (IBM#361)
87ec8b1 
Signed-off-by: Henry Ye <[email protected]>
HCY-11 pushed a commit to HCY-11/aihwkit that referenced this pull request Dec 7, 2022
@maljoras @HCY-11
Add reverse up / down device option (IBM#361)
b252aae 
Signed-off-by: Henry Ye <[email protected]>
HCY-11 pushed a commit to HCY-11/aihwkit that referenced this pull request Dec 7, 2022
@maljoras @HCY-11
Add reverse up / down device option (IBM#361)
68ddded 
Signed-off-by: Henry Ye <[email protected]>
HCY-11 pushed a commit to HCY-11/aihwkit that referenced this pull request Dec 7, 2022
@maljoras @HCY-11
Add reverse up / down device option (IBM#361)
d0a3f2c 
Signed-off-by: Henry Ye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabio-83 Fabio-83 Fabio-83 approved these changes

Assignees

@maljoras maljoras

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maljoras @Fabio-83