Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Suppress lint errors #25

Merged
merged 1 commit into from
Nov 11, 2016
Merged

Conversation

williamwebb
Copy link
Contributor

No description provided.

@williamwebb
Copy link
Contributor Author

The new dependencies are to fix an issue with lambdas & lint described here. The other changes here you should have been seeing. They are described here.

@martinbonnin
Copy link
Collaborator

How can I see these lambdas & lint errors ? My Android studio inspection seems fine (AS 2.2.2). If I run lint from the command line, I get a load of errors but did not see anything okio or lambda related.

I'm not against fixing lint warnings but I'd really like to get to the bottom of this as I haven't seen anything wrong from my side yet.

@williamwebb
Copy link
Contributor Author

On you local run ~./gradlew clean build and it will run through all the lint tasks and generate a report. I will also create a MR with travis-ci integration for future use and it will show these errors.

@martinbonnin
Copy link
Collaborator

Ok, I have an error now. I would have expected this to happen also when building from Android Studio, not only from the command line and also when building assembleDebug and not just 'build'.

Anyway, PR merged, thanks !

@martinbonnin martinbonnin reopened this Nov 11, 2016
@martinbonnin martinbonnin merged commit f41a7c1 into HearthSim:master Nov 11, 2016
@martinbonnin
Copy link
Collaborator

Also, it would be interesting to understand how doing ./gradlew app:lint differs from what Android Studio is doing to display all the yellow tooltips etc.

martinbonnin added a commit that referenced this pull request Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants