更新链接为 Metadata 中的常量，优化代码可维护性 #3674
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glavo
reviewed
Mar 8, 2025
| @@ -53,9 +54,19 @@ public static String getName(SupportedLocale locale) { | |||
| return locale == Locales.DEFAULT ? resourceBundle.getString("lang.default") : locale.getResourceBundle().getString("lang"); | |||
| } | |||
|
|
|||
| private static String replaceURLs(String text) { | |||
There was a problem hiding this comment.
我不喜欢这样修改，我觉得保留 i18n 中的 URL 没问题，或者可以考虑把那些使用 URL 的地方改成插值，在使用处一处处改，而不是直接动 I18N 这个逻辑。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.