Make all tables sortable #3599
Draft
Make all tables sortable #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has access to SC name
…sibility - Replaced header sorting icons with a button for better accessibility. - Added role and data attributes to enhance screen reader support. - Cleaned up unused PropTypes and adjusted styles for consistency.
fpigeonjr
reviewed
Mar 26, 2025
frontend/src/components/BudgetLineItems/AllBudgetLinesTable/AllBudgetLinesTable.hooks.js
Outdated
Show resolved
Hide resolved
- Added aria-sort attribute to table headers for improved screen reader support. - Cleaned up table component structure by removing inline styles for width.
- Added cursor pointer and title attributes to table headers for better user experience. - Simplified the structure by removing unnecessary div wrapper around the table. - Enhanced sorting button title for clarity.
- Moved the sorting button inside the table header for better accessibility. - Added cursor pointer class to the button for improved user interaction. - Adjusted icon margin for better visual alignment.
- Added missing agreement data to the test cases for accurate sorting validation. - Improved test coverage by ensuring all relevant entries are included in the sorted results.
- Removed duplicate `useSetSortConditions` hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Make all data tables sortable by column.
Issue
OPS-976
How to test
Screenshots
If relevant, e.g. for a front-end feature
Definition of Done Checklist
Links
If relevant, e.g. for a link to a piece of markdown documentation