Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cloud SQL from the Cloud Explorer. #970

Merged
merged 1 commit into from
May 24, 2018
Merged

Remove Cloud SQL from the Cloud Explorer. #970

merged 1 commit into from
May 24, 2018

Conversation

ILMTitan
Copy link

Fixes issue #946

@ILMTitan ILMTitan self-assigned this May 24, 2018
@ILMTitan ILMTitan requested review from iantalarico and redborian May 24, 2018 20:30
redborian
redborian approved these changes May 24, 2018
View reviewed changes
Copy link
Contributor

@redborian redborian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The python script to remove unused resource strings is doing work! 👍

@codecov
Copy link

codecov bot commented May 24, 2018

Codecov Report

Merging #970 into master will increase coverage by 0.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
+ Coverage   34.11%   34.82%   +0.71%     
==========================================
  Files         546      528      -18     
  Lines       13451    13070     -381     
==========================================
- Hits         4589     4552      -37     
+ Misses       8862     8518     -344
Impacted Files Coverage Δ
...dExtension/CloudExplorer/CloudExplorerViewModel.cs 76% <ø> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e5ce9...4c7438e. Read the comment docs.

@ILMTitan ILMTitan merged commit 9cbec72 into GoogleCloudPlatform:master May 24, 2018
@ILMTitan ILMTitan deleted the issue-946 branch May 24, 2018 23:48
@ILMTitan
Copy link
Author

Fixes #946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redborian redborian redborian approved these changes

@iantalarico iantalarico Awaiting requested review from iantalarico

Assignees

@ILMTitan ILMTitan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ILMTitan @redborian