Change the lookup for a layer theme field

[simon-leech]

A layer with a field defined in the theme that matches to a template in workspace.templates will error.

  "themes": {
      "a": {
        "title": "Theme A",
        "type": "categorized",
        "field": "theme_field"
   }
}

If there's a layer of the name theme_field - the thematic will fail.

Solution

• Change the lookup from fieldTemplate.template to fieldTemplate.field

 if (Object.hasOwn(req.params.workspace.templates, field)) {
      const fieldTemplate = await getTemplate(field);

    // Previously 
    value = fieldTemplate.template || ''; 
   // New
      value = fieldTemplate.field  || field;
    }

This will mean that the lookup requires a template that contains a field key - which is the SQL for the calculated field for the theme. Also, by setting the || to field, it means that if this is not found - the original field is used.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[dbauszus-glx]

The template must have a field instead of a template string.

{
  "title": "A + B rounded",
  "type": "graduated",
  "field": "a_and_b",
  "template": {
    "key": "a_and_b"
    "field": "round(field_a + field_b)" 
  }
}