Repository page header redesign II: The reredesign #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Watch, Star, and Fork buttons are smaller. - DOI related buttons for owners are placed in place of the original buttons and the buttons are pushed to the row below. - The DOI badge for registered repositories is also in place of the original buttons, with the original buttons pushed to the row below. - Simplified new styling rules so no the original repo/header template doesn't need any changes, except single line GIN header injection. - "Request *New* DOI" when it's not the first. When the repository is ready to re-register (it has been registered but also has changes), we add the word "New" to the "Request DOI" button to make it clear that the button will register the new version of the repository for a new DOI. - Separate button for adding DataCite file (datacite.yml)
Check if a repository is registered when building the repository context instead of just on the front page root dir listing. This way, the DOI badge is rendered in the header on all pages of a repository: Non-root directories, file views, issues, pull requests, wiki pages, etc.
Old GIN-specific function for rendering notice banners. Now included in upstream GOGS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following from #78, I've changed the repository header again as we discussed.
Changes:
datacite.ymlfile existed in the repository root. This functionality is now part of the repository context builder, which makes the information available on all repository pages, but means that we no longer require adatacite.ymlfile to be in the repository root for an already registered repository. I consider this acceptable, since a repository can be modified after registration and should retain its badge.Screenshots
Owner view
Registered repository: front page
Registered repository: file view
Registered repository: wiki page
Unregistered repository: front page
Unregistered repository: file view
Ready to register: front page
Ready to register: file view
NOTE: The buttons change here because without listing the repository's front page, it's unknown whether a
datacite.ymlfile exists in the repository root, which is required for a repository to be ready. I think this is a minor issue and we can address it in the future.Registered and ready: front page
Registered and ready: file view
NOTE: Same issue as above.
Non-owner view
Registered
Unregistered