Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply proxy settings to the PO token web views #6922

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

absidue
Copy link
Member

@absidue absidue commented Feb 25, 2025

Apply proxy settings to the PO token web views

Pull Request Type

  • Bugfix

Related issue

Description

Currently we don't apply the user's configured proxy settings to the separate sessions that we use for the PO token web views. This pull request corrects that. To not impact video loading performance too much I decided to cache the proxy URL in a variable, that way we don't have to make multiple calls to nedb each time a video is opened.

Testing

Set a proxy in FreeTube's proxy settings and check that it works and doesn't cause any new problems.

I used the Charles Proxy app to test this, if you want to do the same you'll need to add this snippet to the src/main/index.js file so that the SSL spoofing works:

app.on('certificate-error', (event, webContents, url, error, certificate, callback) => {
  event.preventDefault()
  // eslint-disable-next-line n/no-callback-literal
  callback(true)
})

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: ce38429

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 25, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 25, 2025 22:38
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with local tor (macos)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: waiting for review For PRs that are complete, tested, and ready for review
Projects
None yet
2 participants