Apply proxy settings to the PO token web views #6922
+16
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply proxy settings to the PO token web views
Pull Request Type
Related issue
Description
Currently we don't apply the user's configured proxy settings to the separate sessions that we use for the PO token web views. This pull request corrects that. To not impact video loading performance too much I decided to cache the proxy URL in a variable, that way we don't have to make multiple calls to nedb each time a video is opened.
Testing
Set a proxy in FreeTube's proxy settings and check that it works and doesn't cause any new problems.
I used the Charles Proxy app to test this, if you want to do the same you'll need to add this snippet to the
src/main/index.js
file so that the SSL spoofing works:Desktop