Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate FtShareButton to composition api #6919

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ChunkyProgrammer
Copy link
Member

Migrate FtShareButton to composition api

Pull Request Type

  • Other - composition api migration

Description

This PR migraties FtShareButton to composition api

Testing

Channel (base tests)

channel share menu (opened)

Copy a YouTube url

  1. go to a channel (ex: https://www.youtube.com/channel/UCX6OQ3DkcsbYNE6H8uQQuVA )
  2. test copying a YouTube url
  3. verify that it is correct by pasting it in a browser

Open a YouTube url

  1. go to a channel (ex: https://www.youtube.com/channel/UCX6OQ3DkcsbYNE6H8uQQuVA )
  2. test opening a YouTube url
  3. verify that a browser window opens with the correct url

Copy an Invidious url

  1. go to a channel (ex: https://www.youtube.com/channel/UCX6OQ3DkcsbYNE6H8uQQuVA )
  2. test copying a Invidious url
  3. verify that it is correct by pasting it in a browser

Open an Invidious url

  1. go to a channel (ex: https://www.youtube.com/channel/UCX6OQ3DkcsbYNE6H8uQQuVA )
  2. test opening a Invidious url
  3. verify that a browser window opens with the correct url

Playlist

playlist share menu (opened)

  1. Repeat tests for channel page but for a playlist (ex: https://youtube.com/playlist?list=PLoSWVnSA9vG9qV0CVCpg5WwEy3LiP7udY )
  2. test copying/opening YouTube and Invidious embeds as well

Video

video share menu (opened)

  1. Repeat tests for channel/playlist page but for a video (ex: https://youtu.be/NDsO1LT_0lw )
  2. test copying/opening YouTube and Invidious links with a timestamp as well (ex: https://youtu.be/NDsO1LT_0lw?t=120 )
  3. test copying/opening YouTube and Invidious links with a playlist (ex: https://youtu.be/NDsO1LT_0lw?list=PLoSWVnSA9vG9qV0CVCpg5WwEy3LiP7udY )

Desktop

  • OS: Fedora Linux
  • OS Version: 41 KDE
  • FreeTube version: latest nightly

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 25, 2025 16:12
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: waiting for review For PRs that are complete, tested, and ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants