Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hide to tray option #6915

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

Conversation

Devenor
Copy link

@Devenor Devenor commented Feb 24, 2025

Added hide to tray option

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

#59

Description

Adds optional hide to system tray behaviour on closing and/or minimizing the main window. The settings have an option to enable or disable it in the general section. The tray icon has a small menu for closing the app or opening the window again, and it can be opened by clicking on the icon too.

Screenshots

https://imgur.com/a/1TVWBJp
https://imgur.com/a/xvBEqFe

Testing

Fully tested on Windows.
The closing behaviour has been adapted for Darwin but has not been tested.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: v0.23.2 Beta

Additional context

@github-actions github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Feb 24, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 24, 2025 22:48
auto-merge was automatically disabled February 24, 2025 23:12

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 24, 2025 23:12
@absidue
Copy link
Member

absidue commented Feb 25, 2025

Please fix the build and revert all unrelated changes such as the dependency additions, there is no need to manually extract anything from the asar file and the translations are overkill at the moment (especially pulling in multiple dependencies just to translate 2 strings).

Even after the corrections there are still open questions such as how to handle multiple windows.

@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Feb 25, 2025
auto-merge was automatically disabled February 25, 2025 18:18

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 25, 2025 18:18
auto-merge was automatically disabled February 25, 2025 18:22

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 25, 2025 18:23
@Devenor
Copy link
Author

Devenor commented Feb 25, 2025

Thanks for the review, I reverted the new dependencies (I didn't know you could read asar directly from node fs! It's much better now). About the i18n, if needed maybe we could send the translated text via IPC and recreate the tray.

As for how to handle multiple windows, I didn't know you could have more than one, is there some kind of setting for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: changes requested PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants