Remove Pumpify since it's broken on Node 10+ #256
Merged
+69
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: mafintosh/pumpify#15 Fortunately Node 10 adds a similar pipeline method built-in Signed-off-by: Liam McLoughlin <[email protected]>
npclaudiu
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: mafintosh/pumpify#15
The result for us is that errors thrown during build can result in the build passing even though there were errors (eg, companion can fail to build and silently not be included.
Fortunately Node 10 adds a similar pipeline method built-in to replace it
For Studio we'll need to use something like https://github.com/dex4er/js-stream.pipeline-shim to polyfill this in the browser.
Signed-off-by: Liam McLoughlin [email protected]