-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add <track> to <video> if there's a .vtt file #289
Comments
I have to guess because I don't have the pretalx db, only the sample. It'd be something like this: https://github.com/jonatron/website/compare/master...jonatron:website:video_track_captions?expand=1 |
Thanks for your contribution! I'll do a check with the actual data from pretalx. |
Just checked adding a track in devtools, I get: |
You should probably only add vtt if it exists. |
I updated the above branch to only add a track if a vtt exists. I also added crossorigin="anonymous", but it'll need |
@gerryd do you know if it's possible to add that CORS header? |
Can you make a PR? I was looking for this for a while but didn't find it because it was an issue and not a PR. |
I actually started doubting my own statement: because we use mirrors, we may not control the cors stuff. But anyway, we can try. |
It might be OK, it looks like currently video files send a location header to a mirror, but the vtt file is served direct. |
#279 (comment) for a larger export file if you want to test on a larger scale. |
Seems to work with that export, thanks. |
It looks like |
Yes, I reverted your patch as you saw. I don't really understand why the CORS would block vtt and not the videos themselves. I can push to our staging environment if we want to test that. |
It's annoying but without crossorigin=anonymous, the track .vtt is blocked but the video isn't, checked using devtools: To proxy the .vtt so it's on the same domain, the nginx conf could look something like:
Not sure if it's worth it or not, it's only a nice to have, and google chrome has live captions built in to the browser. |
Rather than proxying, we could upload the VTT as attachments.
Op do 13 feb 2025, 09:56 schreef jonatron ***@***.***>:
… It's annoying but without crossorigin=anonymous, the track .vtt is blocked
but the video isn't, checked using devtools:
image.png (view on web)
<https://github.com/user-attachments/assets/9eaa925a-6be9-46aa-a6dd-100c4fdaaf59>
To proxy the .vtt so it's on the same domain, the nginx conf could look
something like:
location ~* ^/vtt/(.+\.vtt)$ {
proxy_pass https://video.fosdem.org/$1;
resolver 8.8.8.8;
}
Not sure if it's worth it or not, it's only a nice to have, and google
chrome has live captions built in to the browser.
—
Reply to this email directly, view it on GitHub
<#289 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGUAUUKFATPREUCJRGMDC32PRMHXAVCNFSM6AAAAABWLVGP6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJVHEYDQNJTGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: jonatron]*jonatron* left a comment (FOSDEM/website#289)
<#289 (comment)>
It's annoying but without crossorigin=anonymous, the track .vtt is blocked
but the video isn't, checked using devtools:
image.png (view on web)
<https://github.com/user-attachments/assets/9eaa925a-6be9-46aa-a6dd-100c4fdaaf59>
To proxy the .vtt so it's on the same domain, the nginx conf could look
something like:
location ~* ^/vtt/(.+\.vtt)$ {
proxy_pass https://video.fosdem.org/$1;
resolver 8.8.8.8;
}
Not sure if it's worth it or not, it's only a nice to have, and google
chrome has live captions built in to the browser.
—
Reply to this email directly, view it on GitHub
<#289 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGUAUUKFATPREUCJRGMDC32PRMHXAVCNFSM6AAAAABWLVGP6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJVHEYDQNJTGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Oh yeah, that'd work. I didn't realise attachments are on the fosdem.org domain. |
Just having a look attachments and the interaction between sreview and pretalx and website. Attachments are a |
what, you found the script used for syncing the videos of last year! (I rewrote it, because I didn't) |
We now have .vtt files, from SReview and Whisper, so we can now add captions.
The text was updated successfully, but these errors were encountered: