Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes #223

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Minor changes #223

merged 2 commits into from
Jun 27, 2024

Conversation

ondrej-fabry
Copy link
Member

Changes:

  • add log message when reader closes in socketclient
  • tweak colors in govpp diff command
  • code cleanup in codec package
  • enable debug profiling in tests
  • fix integration test README
  • detect VPP crashes in integration tests

@ondrej-fabry ondrej-fabry requested a review from a team June 24, 2024 12:19
@ondrej-fabry ondrej-fabry requested a review from sknat June 27, 2024 13:22
sknat
sknat previously approved these changes Jun 27, 2024
Copy link
Contributor

@sknat sknat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a nitpick but probably not worth bothering with.

VladoLavor
VladoLavor previously approved these changes Jun 27, 2024
@ondrej-fabry ondrej-fabry dismissed stale reviews from VladoLavor and sknat via 111f386 June 27, 2024 13:51
Changes:
- add log message when reader closes in socketclient
- tweak colors in govpp diff command
- code cleanup in codec package
- enable debug profiling in tests
- fix integration test README
- detect VPP crashes in integration tests

Signed-off-by: Ondrej Fabry <[email protected]>
@ondrej-fabry ondrej-fabry merged commit 8e9a2d8 into master Jun 27, 2024
10 checks passed
@ondrej-fabry ondrej-fabry deleted the minor-changes branch June 27, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants