-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with Mohist #3580
Conversation
Why should we care about this PR? You've given no description of why this is necessary, and it seems like the hat permissions work just fine on all supported server platforms. This is something that should probably be fixed in Mohist, not Essentials. |
This simple null-check makes hats working with mods (hybrid-type servers), cuz rn it just throws an exception and doesn't work at all |
Yes, but clearly this is a bug with the hybrid server so a proper fix should be implemented there, so that instead of every plugin fixing this error, it's fixed server side. CraftBukkit / Spigot / Paper do not seem to have this issue. |
That's completely beside my point. The thing is that there should not be a precedent set for random server forks breaking plugins, and then expecting said plugins to clean up after them. This fix needs to be made in Mohist. I'm closing this issue until further notice. |
Agree with pop here. You're implementing the Bukkit API wrong. Essentials runs on Bukkit servers, if it doesn't: there's a problem with your implementation. |
Mohist's support for modded items creates duplicated |
No description provided.