Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Mohist #3580

Closed
wants to merge 1 commit into from
Closed

Fix compatibility with Mohist #3580

wants to merge 1 commit into from

Conversation

Mgazul
Copy link

@Mgazul Mgazul commented Aug 7, 2020

No description provided.

@pop4959
Copy link
Member

pop4959 commented Aug 7, 2020

Why should we care about this PR? You've given no description of why this is necessary, and it seems like the hat permissions work just fine on all supported server platforms. This is something that should probably be fixed in Mohist, not Essentials.

@pop4959 pop4959 added the type: problem Problems that are not strictly bugs. label Aug 7, 2020
@SSKirillSS
Copy link

SSKirillSS commented Aug 7, 2020

This simple null-check makes hats working with mods (hybrid-type servers), cuz rn it just throws an exception and doesn't work at all

@pop4959
Copy link
Member

pop4959 commented Aug 7, 2020

This simple null-check makes hats working with mods (hybrid-type servers), cuz rn it just throws an exception and doesn't work at all

Yes, but clearly this is a bug with the hybrid server so a proper fix should be implemented there, so that instead of every plugin fixing this error, it's fixed server side. CraftBukkit / Spigot / Paper do not seem to have this issue.

@SSKirillSS
Copy link

Is support almost all forge-platforms via 1 additional line of code - big trouble? 🤔

Also result of test this PR (sorry about encoding):
image

@pop4959 pop4959 added the status: wontfix Issues that will not be resolved, for one reason or another. label Aug 7, 2020
@pop4959
Copy link
Member

pop4959 commented Aug 7, 2020

Is support almost all forge-platforms via 1 additional line of code - big trouble? 🤔

That's completely beside my point. The thing is that there should not be a precedent set for random server forks breaking plugins, and then expecting said plugins to clean up after them.

This fix needs to be made in Mohist. I'm closing this issue until further notice.

@pop4959 pop4959 closed this Aug 7, 2020
@JRoy
Copy link
Member

JRoy commented Aug 7, 2020

Agree with pop here. You're implementing the Bukkit API wrong.

Essentials runs on Bukkit servers, if it doesn't: there's a problem with your implementation.

@mdcfe
Copy link
Member

mdcfe commented Aug 8, 2020

Mohist's support for modded items creates duplicated Material entries, when in Java enum constants should be unique. As pointed out repeatedly to Mohist users and developers, this is a Mohist bug, and we will not be including a workaround in EssentialsX.

@webserfer

This comment has been minimized.

@Outfit8TSB

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wontfix Issues that will not be resolved, for one reason or another. type: problem Problems that are not strictly bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants