Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip : ajout de clés de traduction dans l'interface corpus #1308

Merged
merged 5 commits into from
Mar 4, 2025

Conversation

gromettoclara
Copy link
Collaborator

wip identification des valeurs et dur et remplacement clés traduites

Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for stylo-docs canceled.

Name Link
🔨 Latest commit e832453
🔍 Latest deploy log https://app.netlify.com/sites/stylo-docs/deploys/67c20daa113de70008eb2bf2

@gromettoclara gromettoclara linked an issue Feb 27, 2025 that may be closed by this pull request
@@ -52,12 +52,12 @@ export default function CorpusCreate({ onSubmit }) {
})
onSubmit()
setToast({
text: `New corpus created`,
text: {t('corpus.create.toastSuccess')},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gromettoclara ici, comme on n'est pas dans une balise React, y'a pas besoin de mettre les { / }. Ça produit une erreur de syntaxe JS.

Suggested change
text: {t('corpus.create.toastSuccess')},
text: t('corpus.create.toastSuccess'),

@@ -75,7 +75,7 @@ export default function CorpusCreate({ onSubmit }) {
type="text"
/>
<div className={styles.controlField}>
<label>Description</label>
<label>{t('corpus.createForm.descriptionField')}</label>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ici c'est ok les accolades pour faire appel à du JS dans les templates justement.

@thom4parisot thom4parisot force-pushed the fix/corpus-interface-traduction branch from 8430321 to b919c3a Compare February 27, 2025 13:08
Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for stylo-dev ready!

Name Link
🔨 Latest commit e832453
🔍 Latest deploy log https://app.netlify.com/sites/stylo-dev/deploys/67c20daa1e565600080244db
😎 Deploy Preview https://deploy-preview-1308--stylo-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thom4parisot thom4parisot force-pushed the fix/corpus-interface-traduction branch from b919c3a to ff0de00 Compare February 27, 2025 13:10
@thom4parisot thom4parisot force-pushed the fix/corpus-interface-traduction branch from ff0de00 to 2c08069 Compare February 27, 2025 13:12
@thom4parisot
Copy link
Member

@gromettoclara ah par contre désolé, j'ai "squashé" les commits avec l'intention de fusionner la proposition et je n'ai vu que tardivement le "wip" dans le titre. Ça te demandera une petite manip pour raccrocher cette branche à ton espace local.

J'ai identifié ces éléments :

title="Download a printable version"

title="Preview (open a new window)"

Y'a un bouton "Create draft PR" pour signaler qu'elle est en cours de travaux et empêcher de la rendre fusionnable (wip: c'est le même mécanisme mais sur GitLab).

@gromettoclara
Copy link
Collaborator Author

trop tard pour convert to draft ?

@gromettoclara gromettoclara marked this pull request as draft February 27, 2025 14:21
add keys pour traduction CorpusItem.jsx
i18n : ajout et traduction des clés manquantes
traduction et ajout des clés manquantes pour CorpusItem.jsx
ajout des clés dans les templates
@gromettoclara gromettoclara marked this pull request as ready for review February 28, 2025 19:28
@thom4parisot thom4parisot merged commit 0b5941c into master Mar 4, 2025
8 checks passed
@thom4parisot thom4parisot deleted the fix/corpus-interface-traduction branch March 4, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ajout de clés de traduction dans l'interface -- corpus
2 participants