Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: permet de configurer un volume pour les données y.js #1248

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

ggrossetie
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for stylo-docs canceled.

Name Link
🔨 Latest commit ce55ed1
🔍 Latest deploy log https://app.netlify.com/sites/stylo-docs/deploys/67a3913c0b87f70007b71409

@ggrossetie ggrossetie merged commit 951a3bd into master Feb 5, 2025
8 checks passed
@@ -22,7 +21,7 @@ const LocalStrategy = require('passport-local').Strategy
const OAuthStrategy = require('passport-oauth1')
const { logger } = require('./logger')
const pino = require('pino-http')({
logger
logger,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a une config prettier différente ? J'ai l'impression que le reformattage est différent selon nos IDE.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonne question... Je vais vérifier mon IDE mais je crois que ça applique la configuration du projet 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne vois pas de différence si je lance prettier sur ce fichier. Est-ce que tu as le même comportement ? Est-ce que ton IDE formatte le code en utilisant uniquement prettier ?

Comment on lines +23 to +24
volumes:
- ./data/ydata:/data/ydata
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y'a une raison de ne pas le faire sur le fichier ./docker-compose.yaml (à la racine du dépôt) ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne savais pas trop ce qui est attendu en mode développement local donc j'ai laissé le comportement actuel avec les données dans le conteneur mais comme on a déjà un /data pour la base de données on peut sûrement faire la même chose.

Copy link

sentry-io bot commented Feb 12, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: prevLogger.child is not a function Object.?(app) View Issue
  • ‼️ TypeError: Cannot destructure property 'zoteroToken' of 'undefined' as it is undefined. ?(app) View Issue
  • ‼️ TypeError: Cannot destructure property 'token' of 'undefined' as it is undefined. ?(app) View Issue

Did you find this useful? React with a 👍 or 👎

@thom4parisot thom4parisot deleted the fix/ydata-volume branch February 12, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants