-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: permet de configurer un volume pour les données y.js #1248
Conversation
✅ Deploy Preview for stylo-docs canceled.
|
@@ -22,7 +21,7 @@ const LocalStrategy = require('passport-local').Strategy | |||
const OAuthStrategy = require('passport-oauth1') | |||
const { logger } = require('./logger') | |||
const pino = require('pino-http')({ | |||
logger | |||
logger, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a une config prettier
différente ? J'ai l'impression que le reformattage est différent selon nos IDE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonne question... Je vais vérifier mon IDE mais je crois que ça applique la configuration du projet 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je ne vois pas de différence si je lance prettier sur ce fichier. Est-ce que tu as le même comportement ? Est-ce que ton IDE formatte le code en utilisant uniquement prettier ?
volumes: | ||
- ./data/ydata:/data/ydata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y'a une raison de ne pas le faire sur le fichier ./docker-compose.yaml
(à la racine du dépôt) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je ne savais pas trop ce qui est attendu en mode développement local donc j'ai laissé le comportement actuel avec les données dans le conteneur mais comme on a déjà un /data
pour la base de données on peut sûrement faire la même chose.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
No description provided.