cam6_4_080: Derive new geopotential fields whenever water species are updated (not just water vapor)

[jimmielin]

Fixes #1286.

[PeterHjortLauritzen]

Looks good (just a little suggestion but either way is fine with me) thanks!

[PeterHjortLauritzen]

I think you could also do:

const_water_loop: do m = dry_air_species_num + 1, thermodynamic_active_species_num
   if(ptend%lq(m)) then
                ! is water species?
                derive_new_geopotential = .true.
                exit const_water_loop
  end if
end do

[jimmielin]

Thanks @PeterHjortLauritzen, that makes more sense, updated!

I will update with the regression tests results when they're available to see which compsets need a closer science check...

[jimmielin]

It looks like I had to change

if(ptend%lq(m)) then

to

if(ptend%lq(thermodynamic_active_species_idx(m))) then

as otherwise the m indexing is not correctly translated to the constituent indices. I got a CAM6 test failure when finalizing the regression tests and realized that the indexing had to be fixed. I am rerunning the tests now.

[PeterHjortLauritzen]

good catch!

[jimmielin]

I ran the Derecho Intel and Izumi NAG regression tests to check which compsets are affected by this change. This should only change answers if physics schemes accumulate tendencies, depend on geopotential height, and have intermediate tendencies that do not update water vapor but update other water species.

The good news is that it seems like only the CAM4 physics are affected because of the issue impacting RK (detrainment of convective condensate into cloud liquid water has a tendency update and the following cldwat call uses zi). So it might not affect other compsets after all:

Izumi nag shows only CAM4 physics

aux_cam_nag_20250324131103: 34 tests
  ERC_D_Ln9.ne16_ne16_mg17.QPC4.izumi_nag.cam-outfrq3s_usecase (Overall: DIFF) details:
    FAIL ERC_D_Ln9.ne16_ne16_mg17.QPC4.izumi_nag.cam-outfrq3s_usecase BASELINE /fs/cgd/csm/models/atm/cam/pretag_bl/cam6_4_079_nag: DIFF
  ERC_D_Ln9.ne16pg3_ne16pg3_mg17.QPC4.izumi_nag.cam-outfrq3s_usecase (Overall: DIFF) details:
    FAIL ERC_D_Ln9.ne16pg3_ne16pg3_mg17.QPC4.izumi_nag.cam-outfrq3s_usecase BASELINE /fs/cgd/csm/models/atm/cam/pretag_bl/cam6_4_079_nag: DIFF
  SMS_D_Ln3.ne5pg3_ne5pg3_mg37.QPX2000.izumi_nag.cam-outfrq3s (Overall: DIFF) details:
    FAIL SMS_D_Ln3.ne5pg3_ne5pg3_mg37.QPX2000.izumi_nag.cam-outfrq3s BASELINE /fs/cgd/csm/models/atm/cam/pretag_bl/cam6_4_079_nag: DIFF
  SMS_D_Ln6.ne5_ne5_mg37.QPWmaC4.izumi_nag.cam-outfrq3s_physgrid_tem (Overall: DIFF) details:
    FAIL SMS_D_Ln6.ne5_ne5_mg37.QPWmaC4.izumi_nag.cam-outfrq3s_physgrid_tem BASELINE /fs/cgd/csm/models/atm/cam/pretag_bl/cam6_4_079_nag: DIFF

Derecho Intel shows CAM4 (QPX2000) and the others are expected failures:

aux_cam_intel_20250324131610: 53 tests
  ERP_D_Ln9.ne30pg3_ne30pg3_mt232.QPC7.derecho_intel.cam-outfrq3s_cosp (Overall: FAIL) details:
    FAIL ERP_D_Ln9.ne30pg3_ne30pg3_mt232.QPC7.derecho_intel.cam-outfrq3s_cosp COMPARE_base_rest
  ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s (Overall: FAIL) details:
    FAIL ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s COMPARE_base_rest
    FAIL ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s BASELINE /glade/campaign/cesm/community/amwg/cam_baselines/cam6_4_079_intel: DIFF
  ERS_Ln9.ne30pg3_ne30pg3_mg17.FHISTC_WXma.derecho_intel.cam-outfrq9s (Overall: FAIL) details:
    FAIL ERS_Ln9.ne30pg3_ne30pg3_mg17.FHISTC_WXma.derecho_intel.cam-outfrq9s COMPARE_base_rest
  SMS_D_Ln9.ne16_ne16_mg17.QPX2000.derecho_intel.cam-outfrq9s_amie (Overall: DIFF) details:
    FAIL SMS_D_Ln9.ne16_ne16_mg17.QPX2000.derecho_intel.cam-outfrq9s_amie BASELINE /glade/campaign/cesm/community/amwg/cam_baselines/cam6_4_079_intel: DIFF
  SMS_D_Ln9_P1280x1.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.FHIST.derecho_intel.cam-outfrq9s (Overall: FAIL) details:
    FAIL SMS_D_Ln9_P1280x1.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.FHIST.derecho_intel.cam-outfrq9s RUN time=44
  SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s (Overall: FAIL) details:
    FAIL SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s SETUP