Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCPP'ize dme_adjust #1265

Open
wants to merge 9 commits into
base: cam_development
Choose a base branch
from

Conversation

cacraigucar
Copy link
Collaborator

closes #1090

Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cacraigucar!

@@ -36,7 +36,7 @@
[submodule "atmos_phys"]
path = src/atmos_phys
url = https://github.com/ESCOMP/atmospheric_physics
fxtag = atmos_phys0_08_000
fxtag = atmos_phys0_??_???
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a reminder to update this to the official tag.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update once the atmospheric_physics tag is made

Merge pull request ESCOMP#1214 from PeterHjortLauritzen/clean-up-bugfix
First round of work on CCPP'izing PUMAS
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just going through this again to make sure it was up to date after the reviews in atmos_phys and noticed something unrelated that might need confirming again. Thanks!

@cacraigucar cacraigucar requested a review from jimmielin March 27, 2025 23:00
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cacraigucar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants