Rayleigh Friction to CCPP #1245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusbaume
requested changes
Mar 10, 2025
Comment on lines
+25
to
+26
| rayleigh_friction_initO, & ! Initialization | ||
| rayleigh_friction_tendO ! Computation of tendencies |
There was a problem hiding this comment.
Definite nit-pick, but could we change the name of these subroutines to something like the following:
Suggested change
| rayleigh_friction_initO, & ! Initialization | |
| rayleigh_friction_tendO ! Computation of tendencies | |
| rayleigh_friction_cam_init, & ! Initialization | |
| rayleigh_friction_cam_tend ! Computation of tendencies |
This is just because it took me a second to realize why the 0 was there (although if you prefer the 0 please let me know!).
cacraigucar
requested changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to merge this one up too, but here's the PR for Rayleigh Friction to CCPP!
Fixes #1153