Remove Dimension::Undefined
#188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 25, 2019 10:24
Swift bindings
Implement js bindings
This was referenced Jun 23, 2022
Weibye
commented
Jun 23, 2022
|
I suspect the current failures comes from Measure functions assuming |
|
The generated files are still showing in the review. Is #149 not working as intended? |
* Cleanup `new_with_children()` uses * Format * Update scripts/gentest/src/main.rs Co-authored-by: Alice Cecile <[email protected]>
Updates the requirements on [rstest](https://github.com/la10736/rstest) to permit the latest version. - [Release notes](https://github.com/la10736/rstest/releases) - [Changelog](https://github.com/la10736/rstest/blob/master/CHANGELOG.md) - [Commits](la10736/rstest@0.14.0...0.15.0) --- updated-dependencies: - dependency-name: rstest dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Forest unit tests * Removing old Forest compute_layout uses * Forest unit tests additions and refactoring * Code style adjustments * Removing Forest node_measure_eq warning Co-authored-by: Alice Cecile <[email protected]>
…oxusLabs#196) * feat: use slab instead of bespoke arena * fix: all but one test * chore: rip out forest and merge it into taffy * fix: final tests * polish: fix up some warnings * chore: clean up forest and data fails * chore: make clippy happier * fix: compilation for no-std targets * chore: clean up some more clippy stuff and renable more tests * chore: remove outdated indexmap * fix: update benches to not unwrap new elements * fix: revert back to errors everywhere * fix: revert complex bench too * chore: remove unused import * fix: removing parents * chore: clean up and remove references to forest * chore: remove final reference to forest * chore: update release log * Update error name in RELEASES * Add single parent fix to RELEASES * Remove extra whitespace * chore: add warning to mark dirty function Co-authored-by: Alice Cecile <[email protected]>
|
🤔 Tests fails on height calculation but all width calculations are correct. Trying to dig into why that is but progress is slow (lots of new things to learn) |
|
Going to close this out: this will be a pain to rebase. Anyone can feel free to remake this though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #114
Replaces #160 and #148
Context
The new Resolve-traits really helped clean this up :)
Feedback wanted
simple_childtest are failing