-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-346 Unify dependency manager tests #67
Merged
ncreated
merged 15 commits into
master
from
ncreated/RUMM-346-unify-dependency-manager-tests
Apr 6, 2020
Merged
RUMM-346 Unify dependency manager tests #67
ncreated
merged 15 commits into
master
from
ncreated/RUMM-346-unify-dependency-manager-tests
Apr 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e84248a
to
763d29c
Compare
ℹ️ let's merge #68 before this one |
763d29c
to
f19191f
Compare
buranmert
suggested changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a couple of questions
…ject.pbxproj` for SPM test
…bility for `dd-sdk-ios`
buranmert
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR unifies Carthage, Cocoa Pods and SPM test projects.
How?
Now, all projects behave the same:
cd <test-project> && make
sources project to use current git branch;bitrise.yml
runs unit tests and UI tests for each project and exports artifacts to Bitrise;testCallingLogicThatLoadsSDK()
unit test calls basic SDK logic;testDisplayingUI()
UI test launches the app and asserts that "Testing ..." label is visible;iOS 13.0
;App Target
Every app target is just "Single View" app with default code + invocation of
Datadog
SDK.UI Tests

Every test project has this basic UI and asserts the label is visible:
Unit Tests
Unit tests just invoke
vc.viewDidLoad()
, which guarantees that SDK is linked, loaded and run with no runtime error.Code Signing
3
.xcconfigs
are shared between all projects:where
datadog.xcodeproj
is git-ignored as it might contain our secrets.Review checklist