Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-346 Unify dependency manager tests #67

Merged
merged 15 commits into from
Apr 6, 2020

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Apr 3, 2020

What and why?

📦 This PR unifies Carthage, Cocoa Pods and SPM test projects.

How?

Now, all projects behave the same:

  • cd <test-project> && make sources project to use current git branch;
  • bitrise.yml runs unit tests and UI tests for each project and exports artifacts to Bitrise;
  • testCallingLogicThatLoadsSDK() unit test calls basic SDK logic;
  • testDisplayingUI() UI test launches the app and asserts that "Testing ..." label is visible;
  • dedicated Build Phase runs linter;
  • deployment target is set to iOS 13.0;
  • Code Signing is configured for app target, unit test target and UI test target.

App Target
Every app target is just "Single View" app with default code + invocation of Datadog SDK.

UI Tests
Every test project has this basic UI and asserts the label is visible:
Screenshot 2020-04-03 at 17 07 08

Unit Tests
Unit tests just invoke vc.viewDidLoad(), which guarantees that SDK is linked, loaded and run with no runtime error.

Code Signing
3 .xcconfigs are shared between all projects:

Screenshot 2020-04-03 at 17 12 17

where datadog.xcodeproj is git-ignored as it might contain our secrets.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference

@ncreated ncreated requested review from a team as code owners April 3, 2020 15:14
@ncreated ncreated self-assigned this Apr 3, 2020
@ncreated ncreated force-pushed the ncreated/RUMM-346-unify-dependency-manager-tests branch from e84248a to 763d29c Compare April 3, 2020 15:22
@buranmert
Copy link
Contributor

ℹ️ let's merge #68 before this one

@ncreated ncreated force-pushed the ncreated/RUMM-346-unify-dependency-manager-tests branch from 763d29c to f19191f Compare April 6, 2020 08:32
@ncreated ncreated changed the base branch from ncreated/RUMM-346-fix-crash-on-device-out-of-memory to master April 6, 2020 08:37
Copy link
Contributor

@buranmert buranmert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a couple of questions

Copy link
Contributor

@buranmert buranmert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@ncreated ncreated merged commit 1091b4e into master Apr 6, 2020
@buranmert buranmert deleted the ncreated/RUMM-346-unify-dependency-manager-tests branch April 24, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants