RUMM-182 Sync logs time with server time

[buranmert]

What and why?

• SDK needs to send current date in miliseconds in order for the backend to be able to tell time difference between the device and actual time.
• This is especially essential for tracing among different systems.

How?

1. DataUploadURL can change query of its URL dynamically
2. URLQueryProvider is made enum so that we limit the number of cases to test

Review checklist

• Feature or bugfix MUST have appropriate tests (unit, integration)
• Make sure each commit and the PR mention the Issue number or JIRA reference

[ncreated]

I like it 🏅. Let me know WDYT about my ideas 🙂.

[mariusc83]

it is a bit confusing to keep naming it uploadUrl , why not uploadUrlProvider ?

[mariusc83]

logsUploadUrlProvider ?

[ncreated]

Now I think these tests should remain there, as we lost coverage for se(logsEndpoint:) public API:

[ncreated]

Let's also include test for the code branch which captures overflow, this can be easily done by using "reference date" as relative base:

Suggested change

	}
	}
	func testUInt64Overflow() {
	let dateWithOverflow = Date(timeIntervalSinceReferenceDate: .greatestFiniteMagnitude)
	XCTAssertEqual(dateWithOverflow.currentTimeMillis, UInt64.max)
	}

[buranmert]

good idea 💡
i just noticed i forgot to add tests for init(withReportingOverflow:) too

EDIT done ✅

[ncreated]

We no longer test Configuration.Builder behaviours. In fact, when we switch default endpoint from .us to .eu, none of Swift unit tests do fail.

This will test builder logic:

import XCTest
@testable import Datadog

class DatadogConfigurationTests: XCTestCase {
    private typealias Configuration = Datadog.Configuration

    func testDefaultConfiguration() {
        let defaultConfiguration = Configuration.builderUsing(clientToken: "abcd").build()
        XCTAssertEqual(defaultConfiguration.clientToken, "abcd")
        XCTAssertEqual(defaultConfiguration.logsEndpoint.url, "https://mobile-http-intake.logs.datadoghq.com/v1/input/")
    }

    // MARK: - Logs endpoint
    func testUSLogsEndpoint() {
        let configuration = Configuration.builderUsing(clientToken: .mockAny()).set(logsEndpoint: .us).build()
        XCTAssertEqual(configuration.logsEndpoint.url, "https://mobile-http-intake.logs.datadoghq.com/v1/input/")
    }

    func testEULogsEndpoint() {
        let configuration = Configuration.builderUsing(clientToken: .mockAny()).set(logsEndpoint: .eu).build()
        XCTAssertEqual(configuration.logsEndpoint.url, "https://mobile-http-intake.logs.datadoghq.eu/v1/input/")
    }

    func testCustomLogsEndpoint() {
        let configuration = Configuration.builderUsing(clientToken: .mockAny())
            .set(logsEndpoint: .custom(url: "https://api.example.com/v1/logs/"))
            .build()
        XCTAssertEqual(configuration.logsEndpoint.url, "https://api.example.com/v1/logs/")
    }
}

[buranmert]

copied&pasted ✅

[ncreated]

Those tests do exactly the same assertion as func testItBuildsValidURL() - "When a given URL string is provided, UploadURLProvider decorates it with expected URL queries". Asserting values of the URL for different endpoints (.us, .eu, .custom(...)) is a better fit for configuration builder tests (DatadogConfigurationTests) as we also need to assert the defaults it produces (when no endpoint is set explicitly).

In other words:

• in DataUploaderTests we can test:
  • .us endpoint string
  • .eu endpoint string
  • .custom endpoint string
• in DatadogConfigurationTests we could test:
  • .us endpoint string
  • .eu endpoint string
  • .custom endpoint string
  • default endpoint if not explicitly set by the user 👈

Suggested change

	// MARK: - Logs endpoint
	func testUSLogsEndpoint() {
	let urlUS = Datadog.Configuration.LogsEndpoint.us.url
	let urlProvider = try! UploadURLProvider(
	endpointURL: urlUS,
	clientToken: "abc",
	dateProvider: dateProvider
	)
	XCTAssertEqual(urlProvider.url, URL(string: "https://mobile-http-intake.logs.datadoghq.com/v1/input/abc?ddsource=mobile&batch_time=1576404000000"))
	}
	func testEULogsEndpoint() {
	let urlEU = Datadog.Configuration.LogsEndpoint.eu.url
	let urlProvider = try! UploadURLProvider(
	endpointURL: urlEU,
	clientToken: "abc",
	dateProvider: dateProvider
	)
	XCTAssertEqual(urlProvider.url, URL(string: "https://mobile-http-intake.logs.datadoghq.eu/v1/input/abc?ddsource=mobile&batch_time=1576404000000"))
	}
	func testCustomLogsEndpoint() {
	let urlCustom = Datadog.Configuration.LogsEndpoint.custom(url: "foo.bar").url
	let urlProvider = try! UploadURLProvider(
	endpointURL: urlCustom,
	clientToken: "abc",
	dateProvider: dateProvider
	)
	XCTAssertEqual(urlProvider.url, URL(string: "foo.bar/abc?ddsource=mobile&batch_time=1576404000000"))
	}

[buranmert]

done ✅

[ncreated]

💪