Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUM-8672 Update UserInfo API to make id mandatory. #2195

Merged
merged 3 commits into from
Feb 28, 2025
Merged

RUM-8672 Update UserInfo API to make id mandatory. #2195

merged 3 commits into from
Feb 28, 2025

Conversation

maciejburda
Copy link
Member

@maciejburda maciejburda commented Feb 20, 2025 •
edited
Loading

What and why?

Makes id parameter of setUserInfo() mandatory. Old signature is kept with deprecation warning.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)

@maciejburda maciejburda requested review from a team as code owners February 20, 2025 11:01
@maciejburda maciejburda marked this pull request as draft February 20, 2025 11:01
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 20, 2025 •
edited
Loading

Datadog Report

Branch report: maciey/RUM-8672/mandatory-user-id
Commit report: 60b18f9
Test service: dd-sdk-ios

✅ 0 Failed, 357 Passed, 3459 Skipped, 37.7s Total duration (1m 57.82s time saved)

@maciejburda maciejburda marked this pull request as ready for review February 20, 2025 11:33
barboraplasovska
barboraplasovska previously approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@barboraplasovska barboraplasovska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👌

@maciejburda maciejburda force-pushed the maciey/RUM-8672/mandatory-user-id branch from ccb40c7 to 60b18f9 Compare February 28, 2025 12:22
@maciejburda
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 28, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-02-28 12:22:48 UTC ℹ️ Start processing command /merge

2025-02-28 12:22:51 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-02-28 14:13:13 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in develop is 27m.

2025-02-28 14:53:46 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit a4da69a into develop Feb 28, 2025
15 checks passed
@ncreated ncreated mentioned this pull request Mar 6, 2025
Merged
4 tasks
@maciejburda maciejburda deleted the maciey/RUM-8672/mandatory-user-id branch March 10, 2025 15:03
@maciejburda maciejburda mentioned this pull request Mar 10, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simaoseica-dd simaoseica-dd simaoseica-dd approved these changes

@barboraplasovska barboraplasovska Awaiting requested review from barboraplasovska

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciejburda @barboraplasovska @simaoseica-dd