-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-7795 Anonymous RUM Identifier #2172
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 1013 Passed, 2754 Skipped, 47.38s Total duration (1m 45.5s time saved) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT! Only a few minor comments.
DatadogRUM/Tests/Integrations/AnonymousIdentifierManagerTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great overall 👌 - I only left suggestions on naming and documenting the public API.
Requesting a change tho, to add integration unit tests for this feature. Using real instance of the SDK + proxy and asserting that anonymous ID is generated and inserted into events of two RUM sessions started in two instances of the SDK. I can help and pair on this 🙌
Co-authored-by: Maciek Grzybowski <[email protected]>
7ca3267
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits
👍
Datadog/IntegrationUnitTests/RUM/AnonymousIdentifierTests.swift
Outdated
Show resolved
Hide resolved
c68095c
/merge |
Devflow running:
|
What and why?
Adds capability of tracking anonymous id (enabled by default). This data allows linking sessions coming from the same device.
How?
Following proposal from this RFC (internal) it reuses data store mechanism, and based on configuration it generates and reuses stored identifier.
This identifier is attached to
UserInfo
object (schema already updated), which is enriching other SDK events.Here is corresponding PR for Android:
DataDog/dd-sdk-android#2487
Review checklist
make api-surface
)