Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-7316 Expose Session Replay SwiftUI Feature Flag to Objc #2145

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Dec 12, 2024

What and why?

Follow up #2124

How?

A brief description of implementation details of this PR.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)

@maxep maxep requested review from a team as code owners December 12, 2024 17:46
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 12, 2024

Datadog Report

Branch report: maxep/RUM-7316/swiftui-ff
Commit report: c92cc3b
Test service: dd-sdk-ios

✅ 0 Failed, 3583 Passed, 0 Skipped, 2m 31.43s Total Time
🔻 Test Sessions change in coverage: 4 decreased, 3 increased, 7 no change

🔻 Code Coverage Decreases vs Default Branch (4)

  • test DatadogInternalTests iOS 80.48% (-0.06%) - Details
  • test DatadogInternalTests tvOS 80.46% (-0.05%) - Details
  • test DatadogTraceTests iOS 54.12% (-0.04%) - Details
  • test DatadogCoreTests iOS 71.88% (-0.02%) - Details

simaoseica-dd
simaoseica-dd previously approved these changes Dec 12, 2024
@maxep maxep force-pushed the maxep/RUM-7316/swiftui-ff branch from ba8e1af to c92cc3b Compare December 13, 2024 10:00
@maxep
Copy link
Member Author

maxep commented Dec 13, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 13, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-13 10:34:05 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in develop is 28m.


2024-12-13 11:01:58 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 41aa68a into develop Dec 13, 2024
16 checks passed
@mariedm mariedm deleted the maxep/RUM-7316/swiftui-ff branch December 17, 2024 09:25
@maciejburda maciejburda mentioned this pull request Jan 2, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants