Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-5083 chore: Lower Batch Metrics sample rate to 10% of its original value #2016

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Aug 23, 2024

What and why?

📦 This PR lowers the sample rate for "Batch Deleted" and "Batch Closed" metrics from 15% to 1.5%.

Counterpart of DataDog/dd-sdk-android#2146

How?

Leveraging metric-specific sample rate configuration added in #2015, this PR changes sampleRate in batch metrics from default 15% to custom 1.5%.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

@ncreated ncreated requested review from a team as code owners August 23, 2024 08:31
@ncreated ncreated self-assigned this Aug 23, 2024
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: ncreated/RUM-5083/batch-metric-sampling
Commit report: 4f39eaf
Test service: dd-sdk-ios

✅ 0 Failed, 1860 Passed, 0 Skipped, 1m 17.74s Total Time
🔻 Test Sessions change in coverage: 2 decreased, 3 increased, 3 no change

🔻 Code Coverage Decreases vs Default Branch (2)

  • test DatadogLogsTests iOS 45.37% (-1.39%) - Details
  • test DatadogTraceTests iOS 54.26% (-0.06%) - Details

mariedm
mariedm previously approved these changes Aug 23, 2024
ganeshnj
ganeshnj previously approved these changes Aug 26, 2024
Base automatically changed from ncreated/RUM-5083/custom-metric-sampling to develop August 26, 2024 12:34
@ncreated ncreated dismissed stale reviews from ganeshnj and mariedm August 26, 2024 12:34

The base branch was changed.

@ncreated ncreated merged commit d840edc into develop Aug 26, 2024
16 checks passed
@ncreated ncreated deleted the ncreated/RUM-5083/batch-metric-sampling branch August 26, 2024 13:19
@mariedm mariedm mentioned this pull request Sep 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants