RUM-5083 chore: Lower Batch Metrics sample rate to 10% of its original value #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to 10% of its original value
Datadog ReportBranch report: ✅ 0 Failed, 1860 Passed, 0 Skipped, 1m 17.74s Total Time 🔻 Code Coverage Decreases vs Default Branch (2) |
mariedm
previously approved these changes
Aug 23, 2024
ganeshnj
previously approved these changes
Aug 26, 2024
Base automatically changed from
ncreated/RUM-5083/custom-metric-sampling
to
develop
August 26, 2024 12:34
ncreated
dismissed stale reviews from ganeshnj and mariedm
The base branch was changed.
maxep
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR lowers the sample rate for "Batch Deleted" and "Batch Closed" metrics from 15% to 1.5%.
Counterpart of DataDog/dd-sdk-android#2146
How?
Leveraging metric-specific sample rate configuration added in #2015, this PR changes
sampleRatein batch metrics from default 15% to custom 1.5%.Review checklist