Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mark Alamofire extension types deprecated #1988

Merged
merged 2 commits into from
Aug 5, 2024
Merged

chore: mark Alamofire extension types deprecated #1988

merged 2 commits into from
Aug 5, 2024

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Aug 5, 2024 •
edited
Loading

What and why?

Customers are not fully aware that extension is no longer support from APIs.

How?

Marked all the Alamofire types as deprecated with suggesting to use URLSessionInstrumentation

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

@ganeshnj ganeshnj marked this pull request as ready for review August 5, 2024 11:04
@ganeshnj ganeshnj requested review from a team as code owners August 5, 2024 11:04
maxep
maxep approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ganeshnj ganeshnj merged commit 088d191 into develop Aug 5, 2024
16 checks passed
@ganeshnj ganeshnj deleted the ganeshnj/chore/alamofire-type-deprecated branch August 5, 2024 13:41
@ganeshnj ganeshnj mentioned this pull request Aug 19, 2024
Merged
3 tasks
@maxep maxep mentioned this pull request Aug 20, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

@maxep maxep maxep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganeshnj @ncreated @maxep