Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-2903 fix: refresh rate vital for variable refresh rate displays when over performing #1973

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

ganeshnj
Copy link
Contributor

What and why?

Last time when we touched this area, we normalized the FPS relative to the expected rendering rate for variable refresh rate displays.

ie when a display is rendering at 30fps and expected rate is also 30fps, we report 60fps. This is because our backend only supports 60fps and renders useful indicators.

However, in some case, it has been observed that sometimes display renders quicker than expected.

ie when a display is rendering at 45fps and expected rate is 30fps, in this case normalization doesn't work and we go on to report 90fps which is not correct.

How?

  • For variable refresh rate displays, if the refresh rate goes above the 60fps, we cap the FPS to 60fps.
  • There is no change in the behavior for fixed refresh rate displays.
  • There is no change in the behavior for displays rendering slower than expected rate for variable refresh rate displays.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

@ganeshnj ganeshnj changed the title RUM-2903 fix: cap normalized FPS to 60 RUM-2903 fix: refresh rate vital for variable refresh rate displays when over performing Jul 25, 2024
@ganeshnj ganeshnj marked this pull request as ready for review July 25, 2024 14:42
@ganeshnj ganeshnj requested review from a team as code owners July 25, 2024 14:42
@ganeshnj ganeshnj force-pushed the ganeshnj/fix/refresh-rate-cap branch from 8c17aa3 to 1ae110e Compare July 25, 2024 14:59
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯

@ganeshnj ganeshnj merged commit e344012 into develop Jul 26, 2024
16 checks passed
@ganeshnj ganeshnj deleted the ganeshnj/fix/refresh-rate-cap branch July 26, 2024 13:43
@maxep maxep mentioned this pull request Aug 20, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants