Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Ensure scenario cards are added face up to dashboard immediately #400

Merged

Conversation

hudaif747
Copy link
Collaborator

@hudaif747 hudaif747 commented Mar 17, 2025

Description

When scenario cards are added from the library, they should immediately be turned face up (active) instead of appearing flipped down in the dashboard.
Additionally, when scenarios are created with the dialog they should immediately be added face up to the dashboard instead of staying in the library to be added manually.

Cards added from the library to the Dashboard are now added faceUp (ie. in activated state). Scenarios created using the "Create a new Scenario" dialog box are added directly to the dashboard in the activated state instead of showing up in the library and user having to manually add it to the dashboard.

Related Issues

#395

Design Decisions

Performance & Quality

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@hudaif747 hudaif747 requested a review from JonasGilg March 17, 2025 07:20
Copy link
Collaborator

@JonasGilg JonasGilg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works as requested. Can you add a line in the changelog?

Copy link

github-actions bot commented Mar 18, 2025

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 21814d7. ± Comparison against base commit b857453.

♻️ This comment has been updated with latest results.

@hudaif747 hudaif747 merged commit 505166b into feature/migrate-to-new-backend Mar 18, 2025
5 of 6 checks passed
@hudaif747 hudaif747 deleted the feature/scenario-cards-face-up branch March 18, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants