Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Flip up and activate a face down card on clicking anywhere on the card #399

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

hudaif747
Copy link
Collaborator

@hudaif747 hudaif747 commented Mar 14, 2025

Description

Make an inactive card active by clicking anywhere on the card rather than by only clicking on the checkbox

User had to click on cardTooltip checkbox to activate a card. It's now changed into click anywhere on the card in the Inactive state to set it to active (or flip up)

Related Issues

#396

Design Decisions

Performance & Quality

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

Copy link

github-actions bot commented Mar 14, 2025

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit fe6d783. ± Comparison against base commit 9bb6adb.

♻️ This comment has been updated with latest results.

@hudaif747 hudaif747 requested a review from NXXR March 14, 2025 08:43
@hudaif747 hudaif747 self-assigned this Mar 14, 2025
@hudaif747 hudaif747 linked an issue Mar 14, 2025 that may be closed by this pull request
Copy link
Collaborator

@JonasGilg JonasGilg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, looks to work nicely. Can you add a line in the changelog?

@hudaif747 hudaif747 merged commit b857453 into feature/migrate-to-new-backend Mar 18, 2025
5 of 6 checks passed
@hudaif747 hudaif747 deleted the feature/card-flip-on-click branch March 18, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card Flip up anywhere
2 participants