Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #926 fixed #955

Closed
wants to merge 3 commits into from
Closed

Issue #926 fixed #955

wants to merge 3 commits into from

Conversation

skattel49
Copy link
Contributor

@skattel49 skattel49 commented Jul 19, 2021

Closes #926

I have fixed copied the Accounts model to ./accounts/model.py and changed it's name to Profile as instructed

@pep8speaks
Copy link

pep8speaks commented Jul 19, 2021

Hello @skattel49! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 13:1: E302 expected 2 blank lines, found 1

Comment last updated at 2021-07-20 09:49:50 UTC

@skattel49
Copy link
Contributor Author

I have changed the string formatting to f-strings as suggested.

@skattel49 skattel49 closed this Jul 19, 2021
@brylie brylie reopened this Jul 20, 2021
Copy link
Member

@brylie brylie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Remember to run the command python manage.py makemigrations and commit the migrations to this branch.

@brylie brylie mentioned this pull request Aug 17, 2021
5 tasks
@brylie
Copy link
Member

brylie commented Sep 1, 2021

@skattel49, please remember to run python manage.py makemigrations and commit the migration file to this branch. Any changes to a model need to have accompanying migration(s).

@brylie
Copy link
Member

brylie commented Sep 14, 2021

These changes were merged in a separate pull request in order for me to make changes to the branch.

@brylie brylie closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Account and Profile related code to accounts app
3 participants